Reviewed: https://review.opendev.org/c/openstack/neutron/+/865018 Committed: https://opendev.org/openstack/neutron/commit/3d575f8bd066ce2eb46353a49a8c6850ba9e4387 Submitter: "Zuul (22348)" Branch: master
commit 3d575f8bd066ce2eb46353a49a8c6850ba9e4387 Author: Rodolfo Alonso Hernandez <[email protected]> Date: Mon Nov 14 05:26:52 2022 +0100 Add an env variable "PROCESS_TAG" in ``ProcessManager`` Added a new environment variable "PROCESS_TAG" in ``ProcessManager``. This environment variable could be read by the process executed and is unique per process. This environment variable can be used to tag the running process; for example, a container manager can use this tag to mark the a container. This feature will be used by TripleO to identify the running containers with a unique tag. This will make the "kill" process easier; it will be needed just to find the container running with this tag. Closes-Bug: #1991000 Change-Id: I234c661720a8b1ceadb5333181890806f79dc21a ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1991000 Title: [tripleo] Provide a tag to the container that will be used to kill it Status in neutron: Fix Released Status in tripleo: New Bug description: TripleO uses containers to spawn the different processes. Some of these processes (some Neutron agents) also spawn long live child processes that run in parallel to the main one. This is the list of them: * dibbler * dnsmasq * haproxy * keepalived * neutron-keepalived-state-change * radvd TripleO uses a set of scripts that replaces those processes. When Neutron call a script, it actually starts a sidecar container running the needed process. When the agent needs to stop the process, there is a kill script [1] that replaces the "kill" CLI call. This kill script uses the PID of the process to find the container ID and then to send the needed signal (hup, term, kill). To find the container ID, the script reads "/proc/$PID/cgroup" and parses the output. This is a weak method that depends on the output of this file. This bug proposes to spawn the containers with a label: $ podman run --label neutron_tag="container_UUID" This container UUID could be the "ProcessManager.uuid" itself. This UUID will be unique and will identify the container. If passed when created and killed, the kill script can use this UUID to find this specific container: $ podman ps --filter "label=neutron_tag=container_UUID" [1]https://github.com/openstack/tripleo-heat- templates/blob/master/deployment/neutron/kill-script To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1991000/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
