[
https://issues.apache.org/jira/browse/YARN-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539462#comment-13539462
]
Bikas Saha commented on YARN-103:
---------------------------------
bq. Why not use the existing ResourceRequest...
I am trying to create ContainerRequest akin to ContainerRequest in the
MRAppMaster. This object will be used to map a given request for containers to
a requestor object stored a reference (like the TaskAttemptId). This will
enable the AMRMClient to hand back containers to specific tasks (ie assign
containers to requestors) and do the necessary book-keeping. As compared to the
current impl, in which the users are expected to do this assignment on their
own after analyzing the results of the allocated request. This is logically
different from a ResourceRequest which has no provenance info. Sorry this is
not clear in the current code because the requestor reference is not present.
It was giving warnings since its not used in this version of the client.
The other comments have been fixed. ANY is no longer public and so users cannot
use it. Ideally, we should have a YARN ANY constant so that everyone does not
have to redefine it. Perhaps another jira?
bq. AMRMClientImpl.addResourceRequestToAsk - am not sure why this method is
needed. A simple synchronized asks.add should be sufficient
The change of the ResourceRequest comparator to be agnostic of container count
necessitates the check being done in addResourceRequestToAsk. If ask already
contains request FOO for 5 containers then it will not add a request FOO for 6
containers.
Does this comment along with my previous one for interface vs class resolve the
concerns?
> Add a yarn AM - RM client module
> --------------------------------
>
> Key: YARN-103
> URL: https://issues.apache.org/jira/browse/YARN-103
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: YARN-103.1.patch, YARN-103.2.patch, YARN-103.3.patch,
> YARN-103.4.patch, YARN-103.4.wrapper.patch, YARN-103.5.patch,
> YARN-103.6.patch, YARN-103.7.patch
>
>
> Add a basic client wrapper library to the AM RM protocol in order to prevent
> proliferation of code being duplicated everywhere. Provide helper functions
> to perform reverse mapping of container requests to RM allocation resource
> request table format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
