[ 
https://issues.apache.org/jira/browse/YARN-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539637#comment-13539637
 ] 

Siddharth Seth commented on YARN-103:
-------------------------------------

bq. This is the heart of the problem. We don't have a way to say (via the 
audience annotations) that an interface is for read-only use only - and not for 
users to implement. 
Completely agree with this. Do you think it makes sense to add such an 
annotation ?
I don't know the details - but I believe JobControl being a class in the 0.20 
line was problematic - and it had to be changed to an interface. Curious as to 
why that was required.
Marking this as unstable seems to be correct for now - irrespective of whether 
it's a class / interface. I'd be happier with an interface + factory. Like 
Bikas said, this could be resolved at a later point.

bq. The change of the ResourceRequest comparator to be agnostic of container 
count necessitates the check being done in addResourceRequestToAsk. If ask 
already contains request FOO for 5 containers then it will not add a request 
FOO for 6 containers.
I still don't get why this is needed... maybe I'm missing something. The same 
resourceRequest being removed and added back doesn't seem very useful.

Other than this one change, I'm +1 for committing this. Alejandro, Tom - if you 
don't have concerns - I'll commit this in the next couple of days.
                
> Add a yarn AM - RM client module
> --------------------------------
>
>                 Key: YARN-103
>                 URL: https://issues.apache.org/jira/browse/YARN-103
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-103.1.patch, YARN-103.2.patch, YARN-103.3.patch, 
> YARN-103.4.patch, YARN-103.4.wrapper.patch, YARN-103.5.patch, 
> YARN-103.6.patch, YARN-103.7.patch, YARN-103.8.patch
>
>
> Add a basic client wrapper library to the AM RM protocol in order to prevent 
> proliferation of code being duplicated everywhere. Provide helper functions 
> to perform reverse mapping of container requests to RM allocation resource 
> request table format.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to