[ 
https://issues.apache.org/jira/browse/YARN-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated YARN-390:
-------------------------------

    Attachment: YARN-390.1.patch

This patch switches to using {{line.separator}} both in the CLI classes that 
generate the output and the test classes that check expected output.  I've 
converted some of the logic from using {{StringBuffer#append}} to using 
{{PrintWriter#println}}, which is guaranteed to use {{line.separator}}.

With this patch, {{TestYarnCLI}} passes on both Mac and Windows.  I also built 
a distro and tested manually on both platforms.

                
> ApplicationCLI and NodeCLI use hard-coded platform-specific line separator, 
> which causes test failures on Windows
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-390
>                 URL: https://issues.apache.org/jira/browse/YARN-390
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-390.1.patch
>
>
> {{ApplicationCLI}}, {{NodeCLI}}, and the corresponding test {{TestYarnCLI}} 
> all use a hard-coded '\n' as the line separator.  This causes test failures 
> on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to