[ 
https://issues.apache.org/jira/browse/YARN-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated YARN-390:
-------------------------------

    Attachment: YARN-390.2.patch

I'm uploading a new patch to address some feedback about clarity of this 
change.  I've added comments in {{ApplicationCLI}} and {{NodeCLI}} explaining 
that the reason we use {{PrintWriter#println}} is that it's guaranteed to use 
the correct platform line ending.  I also changed the test code to generate the 
expected strings using {{PrintWriter#println}} instead of {{StringUtils#join}}.
                
> ApplicationCLI and NodeCLI use hard-coded platform-specific line separator, 
> which causes test failures on Windows
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-390
>                 URL: https://issues.apache.org/jira/browse/YARN-390
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-390.1.patch, YARN-390.2.patch
>
>
> {{ApplicationCLI}}, {{NodeCLI}}, and the corresponding test {{TestYarnCLI}} 
> all use a hard-coded '\n' as the line separator.  This causes test failures 
> on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to