[
https://issues.apache.org/jira/browse/YARN-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581701#comment-13581701
]
Siddharth Seth commented on YARN-365:
-------------------------------------
Xuan, Thanks for updating the patch. Comments on the latest patch.
There's some formatting issues - exceeding the 80 width limit, spaces after
commas, etc. Also, there's some formatting changes to code which is unrelated
to the patch which should be avoided.
- Don't think the RMNode internal counter for number of queued events should be
exposed. Infact, it can be implemented as a boolean instead of an integer for
now, which gets reset whenever the scheduler tries fetching the list of
container updates. Additional interfaces can be introduced when this behaviour
is changed in the future.
- The nodeUpdateQueue should be cleared early, before sending out the
NodeRemovedEvent - applies to StatusUpdateWhenHealthyTransition,
DeactivateNodeTransition and ReconnectNodeTransition
- getContainerInfoList can be renamed to getContainerUpdates
- In the unit tests, TestRMNodeTransition.setup() can be simplified. Don't
think the 'first' flag is required. Also, testExpiredContainer and
testStatusChange need to be updated after the latest change to the patch.
> Each NM heartbeat should not generate an event for the Scheduler
> ----------------------------------------------------------------
>
> Key: YARN-365
> URL: https://issues.apache.org/jira/browse/YARN-365
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager, scheduler
> Affects Versions: 0.23.5
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: Prototype2.txt, Prototype3.txt, YARN-365.1.patch,
> YARN-365.2.patch, YARN-365.3.patch, YARN-365.4.patch, YARN-365.5.patch,
> YARN-365.6.patch
>
>
> Follow up from YARN-275
> https://issues.apache.org/jira/secure/attachment/12567075/Prototype.txt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
