[ 
https://issues.apache.org/jira/browse/YARN-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586278#comment-13586278
 ] 

Siddharth Seth commented on YARN-365:
-------------------------------------

Almost there. Couple more fixes needed though.
- nextHeartbeat is being accessed by multiple threads (scheduler and main 
dispatcher). Should be volatile.
- There's a race in handling nextHeartBeat. In the 
StatusUpdateWhenHealthyTransition, nextHeartBeat should be set to false before 
generating the event for the scheduler. Otherwise, there's a race between the 
scheduler event being processed (and setting the value to true) and the value 
being set to false.
- Are the updates required to MockNodes.java. They don't seem to be used 
anywhere.
- testStatusChanged can be modified to check the value of the queue size before 
the EXPIRE event. i.e. validate that events are being queued correctly.
                
> Each NM heartbeat should not generate an event for the Scheduler
> ----------------------------------------------------------------
>
>                 Key: YARN-365
>                 URL: https://issues.apache.org/jira/browse/YARN-365
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>    Affects Versions: 0.23.5
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>         Attachments: Prototype2.txt, Prototype3.txt, YARN-365.1.patch, 
> YARN-365.2.patch, YARN-365.3.patch, YARN-365.4.patch, YARN-365.5.patch, 
> YARN-365.6.patch, YARN-365.7.patch, YARN-365.8.patch
>
>
> Follow up from YARN-275
> https://issues.apache.org/jira/secure/attachment/12567075/Prototype.txt

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to