[
https://issues.apache.org/jira/browse/YARN-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589976#comment-13589976
]
Robert Joseph Evans commented on YARN-237:
------------------------------------------
The change looks more or less OK to me. I am not thrilled about how we modify
the data table's init string by looking for the first '{', but I think it is
OK. I just have a few concerns, and most if it deals with my lack of knowledge
about jQuery and localStorage. I know that localStorage is not supported on
all browsers. I also know that localStorage can throw a QUOTA_EXCEEDED
exception. What happens when we run into these situations? Will the page stop
working or will jQuery degrade gracefully and simply not allow us to save the
data. What about if the data stored in the key is not what we expect. Will
jQuery make the page unusable. We currently have tables with the same name on
different pages. If they are not kept in sync there could be some issues with
the data that is saved.
Which brings up another point I am also a bit concerned about the key we are
using as part of the localStorage. The key is the id of the data table. I
would prefer it if we could some how make it obvious that these values are for
a data table, and not some other "apps" storage.
> Refreshing the RM page forgets how many rows I had in my Datatables
> -------------------------------------------------------------------
>
> Key: YARN-237
> URL: https://issues.apache.org/jira/browse/YARN-237
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.0.2-alpha, 0.23.4, 3.0.0
> Reporter: Ravi Prakash
> Assignee: jian he
> Labels: usability
> Attachments: YARN-237.patch
>
>
> If I choose a 100 rows, and then refresh the page, DataTables goes back to
> showing me 20 rows.
> This user preference should be stored in a cookie.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
