[ 
https://issues.apache.org/jira/browse/YARN-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-378:
-----------------------------

    Attachment: YARN-378_2.patch

Thanks, Robert! I've addressed your comments in the  newer patch. In addition, 
I've fixed two failed test cases.

To make code more robust, I do check for the max-retries from both 
YarnConfiguration and client, and make sure it should be at least 1 (error will 
be logged when the configured value is 0 or negative). Test cases are for the 
scenario are added as well.

Also, I've filed YARN-464 to track the problem of making RM inform AM of the 
max-retries. 
                
> ApplicationMaster retry times should be set by Client
> -----------------------------------------------------
>
>                 Key: YARN-378
>                 URL: https://issues.apache.org/jira/browse/YARN-378
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>         Environment: suse
>            Reporter: xieguiming
>            Assignee: Zhijie Shen
>              Labels: usability
>         Attachments: YARN-378_1.patch, YARN-378_2.patch
>
>
> We should support that different client or user have different 
> ApplicationMaster retry times. It also say that 
> "yarn.resourcemanager.am.max-retries" should be set by client. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to