[ 
https://issues.apache.org/jira/browse/YARN-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated YARN-378:
-----------------------------------------

    Attachment: YARN-378_6.patch

Here's the same patch with YARN only changes.

Looked at YARN only changes, some comments:
 - Rename {{ApplicationSubmissionContext.getNumMaxRetries()}} to 
{{ApplicationSubmissionContext.getApplicationMaxRetries()}} to be more specific 
and clear? Similarly in the proto definition and everywhere too?
 - Remove refs to RMAppImpl in the javadoc for 
{{ApplicationSubmissionContext.setNumMaxRetries()}}, it is an internal detail. 
Also point to the configuration item which is public anyways.
 - Expand the description for {{yarn.resourcemanager.am.max-retries}} in 
{{yarn-default.xml}} to also say what global means: That applications can 
specify their intention via the API but that it cannot be more than this limit. 
And that if it is more, then RM will override it.
 - Rename RMAppImpl.numRMAMRetries to globalAMRetries. We should also not check 
globalAMRetires against 0, I think RM should fail if configured with negative 
numbers.
                
> ApplicationMaster retry times should be set by Client
> -----------------------------------------------------
>
>                 Key: YARN-378
>                 URL: https://issues.apache.org/jira/browse/YARN-378
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>         Environment: suse
>            Reporter: xieguiming
>            Assignee: Zhijie Shen
>              Labels: usability
>         Attachments: YARN-378_1.patch, YARN-378_2.patch, YARN-378_3.patch, 
> YARN-378_4.patch, YARN-378_5.patch, YARN-378_6.patch, YARN-378_6.patch
>
>
> We should support that different client or user have different 
> ApplicationMaster retry times. It also say that 
> "yarn.resourcemanager.am.max-retries" should be set by client. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to