[
https://issues.apache.org/jira/browse/YARN-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605560#comment-13605560
]
Alejandro Abdelnur commented on YARN-469:
-----------------------------------------
Looks good, some minor comments:
* SchedulingMode#DEFAULT_MODE could just do a new instantiation, no need for
ReflectionUtils.
* SchedulingMode#parseSchedulingMode(Class...) method, return does not need
'(SchedulingMode)' casting.
* FSParentQueue#recomputeFairShares() I assume the use of hardcoded
DEFAULT_MODE mode will change once we make the scheduling mode configurable,
right?
* SchedulingMode seem it should have to have a method that indicates if the
mode can be used in a non leaf queue (ie, FIFO it cannot).
> Make scheduling mode in FS pluggable
> ------------------------------------
>
> Key: YARN-469
> URL: https://issues.apache.org/jira/browse/YARN-469
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Affects Versions: 2.0.3-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Labels: scheduler
> Attachments: yarn-469.patch, yarn-469.patch
>
>
> Currently, scheduling mode in FS is limited to Fair and FIFO. The code
> typically has an if condition at multiple places to determine the correct
> course of action.
> Making the scheduling mode pluggable helps in simplifying this process,
> particularly as we add new modes (DRF in this case).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
