[ 
https://issues.apache.org/jira/browse/YARN-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613298#comment-13613298
 ] 

Alejandro Abdelnur commented on YARN-469:
-----------------------------------------

+1. Though, there is one naming nit. {{parse(String className)}} 
s/className/mode/ and the javadoc should state that mode can be 'fair', 'fifo' 
or the name of a class implementing {{SchedulingMode}}. 

Mind a new patch with this correction?
                
> Make scheduling mode in FS pluggable
> ------------------------------------
>
>                 Key: YARN-469
>                 URL: https://issues.apache.org/jira/browse/YARN-469
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>              Labels: scheduler
>         Attachments: yarn-469.patch, yarn-469.patch, yarn-469.patch, 
> yarn-469.patch
>
>
> Currently, scheduling mode in FS is limited to Fair and FIFO. The code 
> typically has an if condition at multiple places to determine the correct 
> course of action.
> Making the scheduling mode pluggable helps in simplifying this process, 
> particularly as we add new modes (DRF in this case).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to