[
https://issues.apache.org/jira/browse/YARN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619054#comment-13619054
]
Hadoop QA commented on YARN-382:
--------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576401/YARN-382_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/637//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/637//console
This message is automatically generated.
> SchedulerUtils improve way normalizeRequest sets the resource capabilities
> --------------------------------------------------------------------------
>
> Key: YARN-382
> URL: https://issues.apache.org/jira/browse/YARN-382
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.0.3-alpha
> Reporter: Thomas Graves
> Assignee: Zhijie Shen
> Attachments: YARN-382_1.patch, YARN-382_2.patch, YARN-382_demo.patch
>
>
> In YARN-370, we changed it from setting the capability to directly setting
> memory and cores:
> - ask.setCapability(normalized);
> + ask.getCapability().setMemory(normalized.getMemory());
> + ask.getCapability().setVirtualCores(normalized.getVirtualCores());
> We did this because it is directly setting the values in the original
> resource object passed in when the AM gets allocated and without it the AM
> doesn't get the resource normalized correctly in the submission context. See
> YARN-370 for more details.
> I think we should find a better way of doing this long term, one so we don't
> have to keep adding things there when new resources are added, two because
> its a bit confusing as to what its doing and prone to someone accidentally
> breaking it in the future again. Something closer to what Arun suggested in
> YARN-370 would be better but we need to make sure all the places work and get
> some more testing on it before putting it in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
