[ https://issues.apache.org/jira/browse/YARN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620097#comment-13620097 ]
Hudson commented on YARN-382: ----------------------------- Integrated in Hadoop-trunk-Commit #3549 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3549/]) YARN-382. SchedulerUtils improve way normalizeRequest sets the resource capabilities (Zhijie Shen via bikas) (Revision 1463653) Result = SUCCESS bikas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463653 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerUtils.java > SchedulerUtils improve way normalizeRequest sets the resource capabilities > -------------------------------------------------------------------------- > > Key: YARN-382 > URL: https://issues.apache.org/jira/browse/YARN-382 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Affects Versions: 2.0.3-alpha > Reporter: Thomas Graves > Assignee: Zhijie Shen > Attachments: YARN-382_1.patch, YARN-382_2.patch, YARN-382_demo.patch > > > In YARN-370, we changed it from setting the capability to directly setting > memory and cores: > - ask.setCapability(normalized); > + ask.getCapability().setMemory(normalized.getMemory()); > + ask.getCapability().setVirtualCores(normalized.getVirtualCores()); > We did this because it is directly setting the values in the original > resource object passed in when the AM gets allocated and without it the AM > doesn't get the resource normalized correctly in the submission context. See > YARN-370 for more details. > I think we should find a better way of doing this long term, one so we don't > have to keep adding things there when new resources are added, two because > its a bit confusing as to what its doing and prone to someone accidentally > breaking it in the future again. Something closer to what Arun suggested in > YARN-370 would be better but we need to make sure all the places work and get > some more testing on it before putting it in. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira