[ 
https://issues.apache.org/jira/browse/YARN-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636890#comment-13636890
 ] 

Bikas Saha commented on YARN-549:
---------------------------------

Rename RM_CLIENT_STATE_POLL_INTERVAL to app submission poll interval?

Need to throw the exception. Do we really need to throw an RPC remote exception 
here when we were interrupted while sleeping?
{code}
+      } catch (InterruptedException ie) {
+        RPCUtil.getRemoteException(ie);
+      }
{code}

Why do we need this? Why do we need a try-catch in the first place. the 
function is just throwing the exception right?
{code}
+        if (!(ie instanceof YarnRemoteException)) {
+          ie = RPCUtil.getRemoteException(ie);
+        }
+        throw (YarnRemoteException) ie;
     }
{code}

Can some of the duplicated setup code in rmappmanager test be moved into a 
JUnit @before setup method?
                
> Asynchronous application submission
> -----------------------------------
>
>                 Key: YARN-549
>                 URL: https://issues.apache.org/jira/browse/YARN-549
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: Proposal of Asynchronous Application Submission_v1.pdf, 
> YARN-549.1.patch
>
>
> Currently, when submitting an application, storeApplication will be called 
> for recovery. However, it is a blocking API, and is likely to block 
> concurrent application submissions. Therefore, it is good to make application 
> submission asynchronous, and postpone storeApplication.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to