[ 
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645307#comment-13645307
 ] 

Vinod Kumar Vavilapalli commented on YARN-422:
----------------------------------------------

bq. 1. Semantically, it is a bit strange RM use "AM"NMClient.
Agreed. May be we should just call it NMClient?

bq. 2. Technically, hadoop-yarn-client has dependency on 
hadoop-yarn-server-resourcemanager in test scope. If we want to use AMNMClient 
in AMLauncher, hadoop-yarn-server-resourcemanager needs to add the dependency 
on hadoop-yarn-client, forming a circular dependency.
The dependencies are per scope, so there is not circular dependency either in 
test scope or non-test scope.

Is this patch ready for review? Or just a definition file? Doesn't seem so.

In any case, I think we need to have either
 - separate call-backs for failures on startContainer() and failure on 
stopContainer()
 - or may be just one call-back with the original event-type?
                
> Add AM-NM client library
> ------------------------
>
>                 Key: YARN-422
>                 URL: https://issues.apache.org/jira/browse/YARN-422
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>         Attachments: AMNMClient_Defination.txt, 
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf
>
>
> Create a simple wrapper over the AM-NM container protocol to provide hide the 
> details of the protocol implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to