[ 
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645733#comment-13645733
 ] 

Bikas Saha commented on YARN-422:
---------------------------------

Please be careful about callbacks wrt thread being used and also potential 
locking order/deadlocks. As an example, in AMRMClient, we used different 
threads for actual RPC work and callback. There was a consumer producer pattern 
between the 2 threads using a blocking thread safe queue. The callback thread 
did not hold any locks when calling back up to the client.
                
> Add AM-NM client library
> ------------------------
>
>                 Key: YARN-422
>                 URL: https://issues.apache.org/jira/browse/YARN-422
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>         Attachments: AMNMClient_Defination.txt, 
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf
>
>
> Create a simple wrapper over the AM-NM container protocol to provide hide the 
> details of the protocol implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to