[
https://issues.apache.org/jira/browse/YARN-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665526#comment-13665526
]
Hadoop QA commented on YARN-711:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12584553/YARN-711.6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/994//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/994//console
This message is automatically generated.
> Copy BuilderUtil methods into individual records
> ------------------------------------------------
>
> Key: YARN-711
> URL: https://issues.apache.org/jira/browse/YARN-711
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Jian He
> Attachments: YARN-711.1.patch, YARN-711.2.patch, YARN-711.3.patch,
> YARN-711.4.patch, YARN-711.5.patch, YARN-711.6.patch
>
>
> BuilderUtils is one giant utils class which has all the factory methods
> needed for creating records. It is painful for users to figure out how to
> create records. We are better off having the factories in each record, that
> way users can easily create records.
> As a first step, we should just copy all the factory methods into individual
> classes, deprecate BuilderUtils and then slowly move all code off
> BuilderUtils.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
