[ 
https://issues.apache.org/jira/browse/YARN-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665716#comment-13665716
 ] 

Vinod Kumar Vavilapalli commented on YARN-711:
----------------------------------------------

+1, looks good to me. Will run the tests locally and check it in.
                
> Copy BuilderUtil methods into individual records
> ------------------------------------------------
>
>                 Key: YARN-711
>                 URL: https://issues.apache.org/jira/browse/YARN-711
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Jian He
>         Attachments: YARN-711.1.patch, YARN-711.2.patch, YARN-711.3.patch, 
> YARN-711.4.patch, YARN-711.5.patch, YARN-711.6.patch, YARN-711.7.patch
>
>
> BuilderUtils is one giant utils class which has all the factory methods 
> needed for creating records. It is painful for users to figure out how to 
> create records. We are better off having the factories in each record, that 
> way users can easily create records.
> As a first step, we should just copy all the factory methods into individual 
> classes, deprecate BuilderUtils and then slowly move all code off 
> BuilderUtils.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to