[ https://issues.apache.org/jira/browse/YARN-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683478#comment-13683478 ]
Hadoop QA commented on YARN-588: -------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12587826/YARN-588.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 39 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1241//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1241//console This message is automatically generated. > Two identical utility methods in different classes to build Resource > -------------------------------------------------------------------- > > Key: YARN-588 > URL: https://issues.apache.org/jira/browse/YARN-588 > Project: Hadoop YARN > Issue Type: Improvement > Components: api > Affects Versions: 2.0.3-alpha > Reporter: Sandy Ryza > Assignee: Niranjan Singh > Priority: Minor > Labels: newbie > Attachments: YARN-588.patch, YARN-588.patch, YARN-588.patch, > YARN-588.patch, YARN-588.patch > > > Both Resources and BuilderUtils have a method that takes the same arguments > to build a Resource object. The code doesn't need both of these methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira