[
https://issues.apache.org/jira/browse/YARN-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683660#comment-13683660
]
Sandy Ryza commented on YARN-588:
---------------------------------
The patch looks good to me. My only nit is that there are tabs that have been
added in a few places, which should be reverted back to spaces.
{code}
String host1 = "host1";
org.apache.hadoop.yarn.server.resourcemanager.NodeManager nm1 =
registerNode(host1, 1234, 2345, NetworkTopology.DEFAULT_RACK,
- Resources.createResource(memory, 1));
+ Resource.newInstance(memory, 1));
nm1.heartbeat();
{code}
> Two identical utility methods in different classes to build Resource
> --------------------------------------------------------------------
>
> Key: YARN-588
> URL: https://issues.apache.org/jira/browse/YARN-588
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api
> Affects Versions: 2.0.3-alpha
> Reporter: Sandy Ryza
> Assignee: Niranjan Singh
> Priority: Minor
> Labels: newbie
> Attachments: YARN-588.patch, YARN-588.patch, YARN-588.patch,
> YARN-588.patch, YARN-588.patch
>
>
> Both Resources and BuilderUtils have a method that takes the same arguments
> to build a Resource object. The code doesn't need both of these methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
