[
https://issues.apache.org/jira/browse/YARN-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625414#comment-15625414
]
Daniel Templeton commented on YARN-5811:
----------------------------------------
Thanks for filing the issue, [[email protected]]. In your patch, why
are you also removing the internal close and init methods? Also, in the test
class, you have nested _try_ clauses, but you could put both resources into the
same _try_:
{code}
try (
ConfigurationProvider provider = new LocalConfigurationProvider();
InputStream inputStream = provider.getConfigurationInputStream(...)
) {
{code}
> ConfigurationProvider must implement Closeable interface
> --------------------------------------------------------
>
> Key: YARN-5811
> URL: https://issues.apache.org/jira/browse/YARN-5811
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Denis Bolshakov
> Attachments: YARN-5811.1.patch, YARN-5811.3.patch, YARN-5811.5.patch
>
>
> ConfigurationProvider declares close method, it would be so nice if the class
> implements Closeable interface allowing to use `try with resources`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
