[
https://issues.apache.org/jira/browse/YARN-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688060#comment-15688060
]
Daniel Templeton commented on YARN-5811:
----------------------------------------
I don't see where calling close on {{FileSystemBasedConfigurationProvider}} is
an issue. {{FileSystemBasedConfigurationProvider}} creates the {{FileSystem}}
instance in {{initInternal()}}, and {{fs}} isn't static.
The problem that the inner methods solve is this:
http://stackoverflow.com/questions/5780099/checkstyle-method-not-designed-for-extension-error-being-incorrectly-issued
> ConfigurationProvider must implement Closeable interface
> --------------------------------------------------------
>
> Key: YARN-5811
> URL: https://issues.apache.org/jira/browse/YARN-5811
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Denis Bolshakov
> Priority: Minor
> Labels: newbie
> Attachments: YARN-5811.1.patch, YARN-5811.3.patch, YARN-5811.5.patch,
> YARN-5811.6.patch
>
>
> ConfigurationProvider declares close method, it would be so nice if the class
> implements Closeable interface allowing to use `try with resources`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
