[
https://issues.apache.org/jira/browse/YARN-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634721#comment-15634721
]
Sangjin Lee commented on YARN-5585:
-----------------------------------
Thanks [~rohithsharma] for the latest patch!
In addition to Varun's comments above, I have a few comments.
(TimelineReaderContext.java)
- Do we need to maintain 2 constructors? Now that the entity id prefix is a key
part of this, we should probably drop the old constructor. I presume you could
update this as we update the tests?
(TimelineReaderWebServices.java)
- I am assuming that we will need to add a new method (or methods) that
explicitly supports pagination and connects that to the 2nd branch of logic you
added in {{GenericEntityReader.getResults()}}, right?
(TimelineUIDConverter.java)
- What would we emit as part of the UID if the entity id prefix was not set? An
empty string ("")?
(EntityRowKeyPrefix.java)
- we need to add javadoc to the new method
(GenericEntityReader.java)
- l.85: we should remove {{sortedKeys}} from this constructor too, right?
> [Atsv2] Reader side changes for entity prefix and support for pagination via
> additional filters
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-5585
> URL: https://issues.apache.org/jira/browse/YARN-5585
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Critical
> Labels: oct16-hard
> Attachments: 0001-YARN-5585.patch, YARN-5585-YARN-5355.0001.patch,
> YARN-5585-workaround.patch, YARN-5585.v0.patch
>
>
> TimelineReader REST API's provides lot of filters to retrieve the
> applications. Along with those, it would be good to add new filter i.e fromId
> so that entities can be retrieved after the fromId.
> Current Behavior : Default limit is set to 100. If there are 1000 entities
> then REST call gives first/last 100 entities. How to retrieve next set of 100
> entities i.e 101 to 200 OR 900 to 801?
> Example : If applications are stored database, app-1 app-2 ... app-10.
> *getApps?limit=5* gives app-1 to app-5. But to retrieve next 5 apps, there is
> no way to achieve this.
> So proposal is to have fromId in the filter like
> *getApps?limit=5&&fromId=app-5* which gives list of apps from app-6 to
> app-10.
> Since ATS is targeting large number of entities storage, it is very common
> use case to get next set of entities using fromId rather than querying all
> the entites. This is very useful for pagination in web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
