[
https://issues.apache.org/jira/browse/YARN-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644984#comment-15644984
]
Sangjin Lee commented on YARN-5184:
-----------------------------------
Thanks for your feedback Steve.
I don't think there is a disagreement that the API compatibility has been
broken and that it needs to be restored before it is released. I also believe
that the only way to restore the API compatibility (short of removing the
methods) is to add default implementations.
The proposal on the table is to do just that. The only one more point I'd like
to bring up is what to do for 3.0. If we do this for 2.8/2.9, we would have
introduced new methods with default implementations for 2.8/2.9. Personally I
think it is fine to turn them abstract in 3.0 (the current code). Let me know
what you think.
I'd like to close this soon as this would be a blocker for any 2.x releases as
well as 3.0. Thanks!
> Fix up incompatible changes introduced on ContainerStatus and NodeReport
> ------------------------------------------------------------------------
>
> Key: YARN-5184
> URL: https://issues.apache.org/jira/browse/YARN-5184
> Project: Hadoop YARN
> Issue Type: Bug
> Components: api
> Affects Versions: 2.8.0, 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Sangjin Lee
> Priority: Blocker
> Attachments: YARN-5184-branch-2.8.poc.patch,
> YARN-5184-branch-2.poc.patch
>
>
> YARN-2882 and YARN-5430 broke compatibility by adding abstract methods to
> ContainerStatus. Since ContainerStatus is a Public-Stable class, adding
> abstract methods to this class breaks any extensions.
> To fix this, we should add default implementations to these new methods and
> not leave them as abstract.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
