[ 
https://issues.apache.org/jira/browse/YARN-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645994#comment-15645994
 ] 

Arun Suresh commented on YARN-4597:
-----------------------------------

bq. I also think that should be changed for existing code. The code for sending 
container_launched event should be inside the 'else' block when really 
launching the container.
Aah.. I was worried I would break something else If I moved it inside the else. 
If it is fine to modify the existing path, I'll use the 'shouldLaunchContainer' 
flag.. Thanks.

bq. It will call 'storeContainerQueued' unconditionally, even though the 
container is not queued when it reached the queue-len limit. shouldn't we not 
call storeContainerQueued in that case.
Got it.. Yup, will fix it.




> Add SCHEDULE to NM container lifecycle
> --------------------------------------
>
>                 Key: YARN-4597
>                 URL: https://issues.apache.org/jira/browse/YARN-4597
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: nodemanager
>            Reporter: Chris Douglas
>            Assignee: Arun Suresh
>              Labels: oct16-hard
>         Attachments: YARN-4597.001.patch, YARN-4597.002.patch, 
> YARN-4597.003.patch, YARN-4597.004.patch, YARN-4597.005.patch, 
> YARN-4597.006.patch
>
>
> Currently, the NM immediately launches containers after resource 
> localization. Several features could be more cleanly implemented if the NM 
> included a separate stage for reserving resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to