[
https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648473#comment-15648473
]
Varun Saxena commented on YARN-5739:
------------------------------------
Thanks [~gtCarrera9] for the patch.
Few comments.
# REST endpoint {{/apps/\{appid\}/entities}} sounds more like fetching all
entities across entity types. Should it be {{/apps/\{appid\}/entity-types}}
# Instead of using EntityTypeReader#getNextRowKey, we can use the method Rohith
has copied over from HBase code to GenericEntityReader in YARN-5585. I had
asked him to move it to TimelineStorageUtils. Once YARN-5585 goes in, you can
use that.
# In the Scan object, should we use Scan#setCaching(1) as we do not need more
than one row for every entity type. We can also use PageFilter of size 1.
# In EntityTypeReader#getResult, setting Scan#setMaxVersions is not required.
Default value of 1 should do.
# In EntityTypeReader#readResults, is setting the PrefixFilter necessary ?
Shouldn't we be using Scan#setRowPrefixFilter and pass the start row in that.
# Depends on perspective but EntityTypeReader returning a set of entities looks
somewhat weird. Do we need to make it a subclass of GenericEntityReader just
for reusing parts of augmentParams ?
# Name the relevant methods in Webservices, Reader manager and reader
implementation consistent i.e. either getEntityTypes or listEntityTypes ?
> Provide timeline reader API to list available timeline entity types for one
> application
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5739
> URL: https://issues.apache.org/jira/browse/YARN-5739
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-5739-YARN-5355.001.patch
>
>
> Right now we only show a part of available timeline entity data in the new
> YARN UI. However, some data (especially library specific data) are not
> possible to be queried out by the web UI. It will be appealing for the UI to
> provide an "entity browser" for each YARN application. Actually, simply
> dumping out available timeline entities (with proper pagination, of course)
> would be pretty helpful for UI users.
> On timeline side, we're not far away from this goal. Right now I believe the
> only thing missing is to list all available entity types within one
> application. The challenge here is that we're not storing this data for each
> application, but given this kind of call is relatively rare (compare to
> writes and updates) we can perform some scanning during the read time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
