[
https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649249#comment-15649249
]
Sangjin Lee commented on YARN-5739:
-----------------------------------
I'd like to add to Varun's and Vrushali's comments.
{{EntityTypeReader}} extends {{GenericEntityReader}}, but its sole purpose is
to list the entity types. I understand the rationale for
{{GenericEntityReader}} (to inherit a number of utility features), but it feels
a little awkward. At least, can we override the unnecessary public methods
(e.g. {{getEntity()}} and {{getEntities()}}) to throw an
{{UnsupportedOperationException}}?
I also agree that we probably want to use something like {{entitytypes}} for
the REST endpoint.
For a nit on a few javadoc comments, the beginning verb needs to be in the
third-person. For example, {{TimelineReaderManager.java}} l.183, it should be
"Gets", not "Get".
> Provide timeline reader API to list available timeline entity types for one
> application
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5739
> URL: https://issues.apache.org/jira/browse/YARN-5739
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-5739-YARN-5355.001.patch
>
>
> Right now we only show a part of available timeline entity data in the new
> YARN UI. However, some data (especially library specific data) are not
> possible to be queried out by the web UI. It will be appealing for the UI to
> provide an "entity browser" for each YARN application. Actually, simply
> dumping out available timeline entities (with proper pagination, of course)
> would be pretty helpful for UI users.
> On timeline side, we're not far away from this goal. Right now I believe the
> only thing missing is to list all available entity types within one
> application. The challenge here is that we're not storing this data for each
> application, but given this kind of call is relatively rare (compare to
> writes and updates) we can perform some scanning during the read time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
