[
https://issues.apache.org/jira/browse/YARN-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657870#comment-15657870
]
Jonathan Hung commented on YARN-5746:
-------------------------------------
[~xgong] It looks good to me, just one small nit, on the line {{"Illegal" + "
State of " + configuredState}} you can combine the strings.
bq. Does it make sense to you to move all implementations to parseQueue(...)?
It looks more clean to me. It looks like we don't need to change any of
AbstractCSQueue and CapacitySchedulerConfiguarition.
[~leftnoteasy] can you elaborate on this for me? Do you mean setting the
queue's state inside {{CapacityScheduler#parseQueue}}? I think it makes sense
to leave it at {{AbstractCSQueue#setupQueueConfigs}}, let me know if I am
missing something.
> The state of the parentQueue and its childQueues should be synchronized.
> ------------------------------------------------------------------------
>
> Key: YARN-5746
> URL: https://issues.apache.org/jira/browse/YARN-5746
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler, resourcemanager
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Labels: oct16-easy
> Attachments: YARN-5746.1.patch, YARN-5746.2.patch, YARN-5746.3.patch
>
>
> The state of the parentQueue and its childQeues need to be synchronized.
> * If the state of the parentQueue becomes STOPPED, the state of its
> childQueue need to become STOPPED as well.
> * If we change the state of the queue to RUNNING, we should make sure the
> state of all its ancestor must be RUNNING. Otherwise, we need to fail this
> operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
