[ 
https://issues.apache.org/jira/browse/YARN-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622889#comment-15622889
 ] 

Xuan Gong commented on YARN-5746:
---------------------------------

Thanks for the review. [~ozawa] [~templedf] 
bq. I would like to suggest that we create new state, QueueState.NOT_FOUND, and 
return it instead of returning null. What do you think?

I would like to keep null as the return value here.  In the design doc of 
YARN-5724, we will create a State Machine for the queue, NOT_FOUND does not 
sound like a valid state for me.

Uploaded a new patch to address all other comments.

> The state of the parentQueue and its childQueues should be synchronized.
> ------------------------------------------------------------------------
>
>                 Key: YARN-5746
>                 URL: https://issues.apache.org/jira/browse/YARN-5746
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler, resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>              Labels: oct16-easy
>         Attachments: YARN-5746.1.patch, YARN-5746.2.patch
>
>
> The state of the parentQueue and its childQeues need to be synchronized. 
> * If the state of the parentQueue becomes STOPPED, the state of its 
> childQueue need to become STOPPED as well. 
> * If we change the state of the queue to RUNNING, we should make sure the 
> state of all its ancestor must be RUNNING. Otherwise, we need to fail this 
> operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to