[ 
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663407#comment-15663407
 ] 

Varun Saxena commented on YARN-5877:
------------------------------------

Looked at the code. {{yarn.nodemanager.env-whitelist}} is originally meant to 
allow certain environment variables to be taken from container launch context 
instead of NM system environment (if available) and this, from code, seems to 
work fine even with the changes made in YARN-3853. We will put value from NM 
evnironment only if its not available in container launch context which the 
code pointed out above does.

The code added in YARN-3853 is meant to override the environment variables 
pointed out by you, further. Probably for docker. The variable name is 
whitelist but that should not be confused with NM whitelisting. Should we allow 
similar behavior for other environment variables too i.e. make it a 
configurable list similar to NM whitelist or use NM whitelist ? Well possibly 
it can be, but I am not really sure of the implications.



> Allow all nm-whitelist-env to get overridden during launch
> ----------------------------------------------------------
>
>                 Key: YARN-5877
>                 URL: https://issues.apache.org/jira/browse/YARN-5877
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>
> As per the {{yarn.nodemanager.env-whitelist}} for the configured values 
> should  containers may override rather than use NodeManager's default.
> {code}
>   <property>
>     <description>Environment variables that containers may override rather 
> than use NodeManager's default.</description>
>     <name>yarn.nodemanager.env-whitelist</name>
>     
> <value>JAVA_HOME,HADOOP_COMMON_HOME,HADOOP_HDFS_HOME,HADOOP_CONF_DIR,CLASSPATH_PREPEND_DISTCACHE,HADOOP_YARN_HOME</value>
>   </property>
> {code}
> But only the following containers can override
> {code}
>     whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
>     whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to