[ 
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664571#comment-15664571
 ] 

Sunil G commented on YARN-5877:
-------------------------------

Currently {{whitelistedEnv}} is used to emit special ENV variables which are to 
be with container context. Post YARN-3853, its limited to a set of ENV 
variables such as below.
{code}
    whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
    whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
    whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
    whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
    whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
{code}

So if a user adds HADOOP_MAPRED_HOME to whitelist via 
{{yarn.nodemanager.env-whitelist}} then it will *NOT* be emitted with 
{{whitelistedEnv}}. It will be just set as a normal env variable.
Here if user wants all such variables from {{yarn.nodemanager.env-whitelist}} 
to emit with help of {{whitelistedEnv}} api to {{launch_container.sh}}, then 
proposed solution makes sense to me. But I am not very sure whether all such 
variables configured under  {{yarn.nodemanager.env-whitelist}} is to be emitted 
with help of  {{whitelistedEnv}} api. For eg {{CLASSPATH_PREPEND_DISTCACHE}}.

[~vvasudev] , thoughts?

> Allow all nm-whitelist-env to get overridden during launch
> ----------------------------------------------------------
>
>                 Key: YARN-5877
>                 URL: https://issues.apache.org/jira/browse/YARN-5877
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>
> As per the {{yarn.nodemanager.env-whitelist}} for the configured values 
> should  containers may override rather than use NodeManager's default.
> {code}
>   <property>
>     <description>Environment variables that containers may override rather 
> than use NodeManager's default.</description>
>     <name>yarn.nodemanager.env-whitelist</name>
>     
> <value>JAVA_HOME,HADOOP_COMMON_HOME,HADOOP_HDFS_HOME,HADOOP_CONF_DIR,CLASSPATH_PREPEND_DISTCACHE,HADOOP_YARN_HOME</value>
>   </property>
> {code}
> But only the following containers can override
> {code}
>     whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
>     whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to