[ 
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663266#comment-15663266
 ] 

Bibin A Chundatt edited comment on YARN-5877 at 11/14/16 10:30 AM:
-------------------------------------------------------------------

But when we write {{launch_container.sh}} also shouldn't  we take care of all 
{{nodemanger-whitelist}} could be taken from env  which could help in 
{{Docker}} ?.

If i add new property like {{HADOOP_MAPRED_HOME}} in {{nodemanger-whitelist}} 
during launch {{HADOOP_MAPRED_HOME}} from docker env could be taken by default.

I do aggree that we do have another option to pass as env for each application 
but if {{HADOOP_MAPRED_HOME}} is different in each image then could fail 
randomly rt?

Plz do correct me if i am wrong.


was (Author: bibinchundatt):
But when we write to {{launch_container}} of also shouldn't  we have to take 
care,so that rather than Nodemanager default the system env could be taken 
during launch container too. {{Docker}} case wouldnt this help?. If i add new 
property like {{HADOOP_MAPRED_HOME}} in {{nodemanger-whitelist}} during launch 
{{HADOOP_MAPRED_HOME}} from docker env we could take by default. 

Plz do correct me if i am wrong.

> Allow all nm-whitelist-env to get overridden during launch
> ----------------------------------------------------------
>
>                 Key: YARN-5877
>                 URL: https://issues.apache.org/jira/browse/YARN-5877
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>
> As per the {{yarn.nodemanager.env-whitelist}} for the configured values 
> should  containers may override rather than use NodeManager's default.
> {code}
>   <property>
>     <description>Environment variables that containers may override rather 
> than use NodeManager's default.</description>
>     <name>yarn.nodemanager.env-whitelist</name>
>     
> <value>JAVA_HOME,HADOOP_COMMON_HOME,HADOOP_HDFS_HOME,HADOOP_CONF_DIR,CLASSPATH_PREPEND_DISTCACHE,HADOOP_YARN_HOME</value>
>   </property>
> {code}
> But only the following containers can override
> {code}
>     whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
>     whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to