[
https://issues.apache.org/jira/browse/YARN-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684672#comment-15684672
]
Miklos Szegedi commented on YARN-5890:
--------------------------------------
Thank you for the patch [~yufeigu]!
On the comment: {code}If FairShare is zero, use min(maxShare, available
resource) instead to prevent zero value for maximum AM resource since it
forbids any job running in the queue.{code}
Just a note, you might also want to discuss the case, when fair share is not 0
but so low that we cannot launch any AM. This case might deserve a unit test as
well, since the AM launch is forbidden, despite the fair share 0 case, when, it
is allowed.
{code}set queueA and queueB weight zero.{code}
This is a typo. You need to mention queue1, queue2 and queue3. It would be
helpful to give some more meaningful names to these queues like
queueFSZeroWitMax, queueFSZero, queueFSOne.
{code}
createSchedulingRequestExistingApplication(1024, 1, amPriority, attId1);
...
assertEquals((long) ((memCapacity - 1024) * queue2.getMaxAMShare()),
{code}
It would make sense to extract 1024 and 1 as variables and reuse the variable
name here. It helps with readability.
> FairScheduler should log information about AM-resource-usage and max-AM-share
> for queues
> ----------------------------------------------------------------------------------------
>
> Key: YARN-5890
> URL: https://issues.apache.org/jira/browse/YARN-5890
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-5890.001.patch
>
>
> There are several cases where jobs in a queue or stuck likely because of
> maxAMShare. It is hard to debug these issues without any information.
> At the very least, we need to log both AM-resource-usage and max-AM-share for
> queues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
