[ 
https://issues.apache.org/jira/browse/YARN-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685106#comment-15685106
 ] 

Subru Krishnan commented on YARN-5676:
--------------------------------------

Thanks [~curino] for the patch. It mostly LGTM, couple of minor nits:
  * In {{HashBasedRouterPolicy}}, we should fallback to _default_ queue if 
nothing is specified.
  * Typo in 
{{TestHashBasedRouterPolicy::testHashSreadUniformlyAmongSubclusters}}

> Add a HashBasedRouterPolicy, that routes jobs based on queue name hash.
> -----------------------------------------------------------------------
>
>                 Key: YARN-5676
>                 URL: https://issues.apache.org/jira/browse/YARN-5676
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-2915
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-5676-YARN-2915.01.patch, 
> YARN-5676-YARN-2915.02.patch, YARN-5676-YARN-2915.03.patch, 
> YARN-5676-YARN-2915.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to