[
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691396#comment-15691396
]
Varun Saxena commented on YARN-5877:
------------------------------------
Thanks [~bibinchundatt] for the patch. The approach as such seems fine and is
consistent with previous implementation. Do we however need to provide a
facility for container launch context env to take precedence for some
containers and take default from docker env for some others ? Anyways, that
would need more discussion regarding if there is any use case for this.
Coming to the patch.
# We need to add this config in yarn-default.xml
# getWhitelistEnv can be protected
# Name getWhitelistEnv -> getEnvToBeWhitelisted ? Also javadoc should clearly
indicate what this method is meant for and why derived classes should override
it.
# There is an unused import in ContainerExecutor.
# In LinuxContainerExecutor#getWhitelistEnv, while iterating over the envs
configured, we should trim them before adding them to the set.
I would like to hear from guys who worked in the area of docker support in YARN
as well.
> Allow all nm-whitelist-env to get overridden during launch
> ----------------------------------------------------------
>
> Key: YARN-5877
> URL: https://issues.apache.org/jira/browse/YARN-5877
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Attachments: Dockerfile, YARN-5877.0001.patch, YARN-5877.0002.patch,
> YARN-5877.0003.patch, bootstrap.sh, yarn-site.xml
>
>
> As per the {{yarn.nodemanager.env-whitelist}} for the configured values
> should containers may override rather than use NodeManager's default.
> {code}
> <property>
> <description>Environment variables that containers may override rather
> than use NodeManager's default.</description>
> <name>yarn.nodemanager.env-whitelist</name>
>
> <value>JAVA_HOME,HADOOP_COMMON_HOME,HADOOP_HDFS_HOME,HADOOP_CONF_DIR,CLASSPATH_PREPEND_DISTCACHE,HADOOP_YARN_HOME</value>
> </property>
> {code}
> But only the following containers can override
> {code}
> whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
> whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
> whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
> whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
> whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
