[ 
https://issues.apache.org/jira/browse/YARN-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695051#comment-15695051
 ] 

Sunil G commented on YARN-5877:
-------------------------------

[~varun_saxena] and [~bibinchundatt]

bq.Do we however need to provide a facility for container launch context env to 
take precedence for some containers and take default from docker env for some 
others ? Anyways, that would need more discussion regarding if there is any use 
case for this.
I think we are little early to reach to conclusion on this as we do not have 
any substantial use cases yet.

bq.docker-env-whitelist
To add this new configuration, we have discussed the real causes in detail. And 
this patch is planning to use this as a general config and HADOOP_MAPRED_HOME 
is the only configuration which will be configured via this.
I am still not very convinced with few possible mis uses. 

- How can we prevent user from configuring same config in both configs? If so 
which will get preference ?
- I am still thinking of the explanation to be provided to users for the use of 
this new config? I still think it will be very tough to convince users with 
real usage.

I am bouncing this question again since its the case of a new config to client 
side. :)

Thoughts? 

> Allow all nm-whitelist-env to get overridden during launch
> ----------------------------------------------------------
>
>                 Key: YARN-5877
>                 URL: https://issues.apache.org/jira/browse/YARN-5877
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: Dockerfile, YARN-5877.0001.patch, YARN-5877.0002.patch, 
> YARN-5877.0003.patch, bootstrap.sh, yarn-site.xml
>
>
> As per the {{yarn.nodemanager.env-whitelist}} for the configured values 
> should  containers may override rather than use NodeManager's default.
> {code}
>   <property>
>     <description>Environment variables that containers may override rather 
> than use NodeManager's default.</description>
>     <name>yarn.nodemanager.env-whitelist</name>
>     
> <value>JAVA_HOME,HADOOP_COMMON_HOME,HADOOP_HDFS_HOME,HADOOP_CONF_DIR,CLASSPATH_PREPEND_DISTCACHE,HADOOP_YARN_HOME</value>
>   </property>
> {code}
> But only the following containers can override
> {code}
>     whitelist.add(ApplicationConstants.Environment.HADOOP_YARN_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_COMMON_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_HDFS_HOME.name());
>     whitelist.add(ApplicationConstants.Environment.HADOOP_CONF_DIR.name());
>     whitelist.add(ApplicationConstants.Environment.JAVA_HOME.name());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to