[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703578#comment-15703578
]
Daniel Templeton commented on YARN-4997:
----------------------------------------
Thanks for updating the patch. Since [~kasha] is out for a little while, I'm
jumping back in. Looks like you (pl.) decided to drop the {{synchronized}} and
screw the checkstyle complaint. In the interest of not going in circles, I can
live with that. Other minor nits:
* Can we have {{AllocationConfiguration.getQueueAcls()}} wrap the {{Map}} in a
{{Collections.unmodifiableMap()}}? It makes me a little nervous to expose
mutable data structures in getters.
* The javadoc for {{AllocationFileLoaderService. getDefaultPermissions()}}
should start with a summary sentence that ends with a period. Aside from not
being a good summary, the current first sentence is missing the period.
* In {{FairScheduler}}, you messed up the indentation of the first line of
{{applyChildDefaults()'s}} javadoc.
> Update fair scheduler to use pluggable auth provider
> ----------------------------------------------------
>
> Key: YARN-4997
> URL: https://issues.apache.org/jira/browse/YARN-4997
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Tao Jie
> Attachments: YARN-4997-001.patch, YARN-4997-002.patch,
> YARN-4997-003.patch, YARN-4997-004.patch, YARN-4997-005.patch,
> YARN-4997-006.patch, YARN-4997-007.patch, YARN-4997-008.patch,
> YARN-4997-009.patch
>
>
> Now that YARN-3100 has made the authorization pluggable, it should be
> supported by the fair scheduler. YARN-3100 only updated the capacity
> scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
