[
https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710323#comment-15710323
]
Sangjin Lee commented on YARN-5739:
-----------------------------------
Thanks for the update [~gtCarrera9]. I have some feedback specific to the
refactoring.
(AbstractTimelineStorageReader.java)
- I hate to nitpick on the name, but {{AbstractTimelineStorageReader}} sounds a
little awkward to me. Can we stick to the entity reader names? How about
{{AbstractTimelineEntityReader}} or {{BaseTimelineEntityReader}}? Thoughts?
- l.36: It is bit strange that subclasses such as {{TimelineEntityReader}} are
public, and yet the base class is not. If the extended classes are public, then
the base class (i.e. type) should also be public.
- l.38: nit: let's make {{context}} {{final}}
(ApplicationEntityReader.java)
- I think the {{augmentParams()}} can be improved upon. Is it possible to rely
on the base implementations instead of replicating very similar code to
{{AbstractTimelineStorageReader.augmentParams()}}?
> Provide timeline reader API to list available timeline entity types for one
> application
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5739
> URL: https://issues.apache.org/jira/browse/YARN-5739
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-5739-YARN-5355.001.patch,
> YARN-5739-YARN-5355.002.patch, YARN-5739-YARN-5355.003.patch,
> YARN-5739-YARN-5355.004.patch, YARN-5739-YARN-5355.005.patch
>
>
> Right now we only show a part of available timeline entity data in the new
> YARN UI. However, some data (especially library specific data) are not
> possible to be queried out by the web UI. It will be appealing for the UI to
> provide an "entity browser" for each YARN application. Actually, simply
> dumping out available timeline entities (with proper pagination, of course)
> would be pretty helpful for UI users.
> On timeline side, we're not far away from this goal. Right now I believe the
> only thing missing is to list all available entity types within one
> application. The challenge here is that we're not storing this data for each
> application, but given this kind of call is relatively rare (compare to
> writes and updates) we can perform some scanning during the read time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
