[
https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15720290#comment-15720290
]
Varun Saxena commented on YARN-5739:
------------------------------------
Sorry could not look at it earlier as I was away. Patch LGTM too except a few
small nits.
# In javadoc for TimelineReader#getEntityTypes, there are a few typos. Instead
of below, it should be "A set which contains available timeline entity types,
represented as strings if found, empty otherwise.". Also the line in front of
throws should say "while getting entity types" instead of "while getting
entity".
{code}
190 * @return A set contains available timeine entity types, represented
as
191 * Strings if found, null otherwise.
192 * @throws IOException if any problem occurs while getting entity.
{code}
# The javadoc above EntityTypeReader#getNextRowKey should have application id
instead of application information
{code}
137 * @param currRowKeyPrefix The current prefix that contains user,
cluster,
138 * flow, run, and application information.
{code}
# TimelineReaderManager lines 197 and 198 can be combined into one line.
> Provide timeline reader API to list available timeline entity types for one
> application
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5739
> URL: https://issues.apache.org/jira/browse/YARN-5739
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-5739-YARN-5355.001.patch,
> YARN-5739-YARN-5355.002.patch, YARN-5739-YARN-5355.003.patch,
> YARN-5739-YARN-5355.004.patch, YARN-5739-YARN-5355.005.patch,
> YARN-5739-YARN-5355.006.patch
>
>
> Right now we only show a part of available timeline entity data in the new
> YARN UI. However, some data (especially library specific data) are not
> possible to be queried out by the web UI. It will be appealing for the UI to
> provide an "entity browser" for each YARN application. Actually, simply
> dumping out available timeline entities (with proper pagination, of course)
> would be pretty helpful for UI users.
> On timeline side, we're not far away from this goal. Right now I believe the
> only thing missing is to list all available entity types within one
> application. The challenge here is that we're not storing this data for each
> application, but given this kind of call is relatively rare (compare to
> writes and updates) we can perform some scanning during the read time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
