[ 
https://issues.apache.org/jira/browse/YARN-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722122#comment-15722122
 ] 

Sreenath Somarajapuram commented on YARN-5866:
----------------------------------------------

Looks mostly good to me. One suggestion is that it would be better to comment 
the function arguments instead of removing them. This would maintain code 
readability.
{code}
urlForFindRecord(id /*, modelName, snapshot*/) {
{code}

> [YARN-3368] Fix few issues reported by jshint in new YARN UI
> ------------------------------------------------------------
>
>                 Key: YARN-5866
>                 URL: https://issues.apache.org/jira/browse/YARN-5866
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-ui-v2
>            Reporter: Akhil PB
>            Assignee: Akhil PB
>         Attachments: YARN-5866.001.patch, YARN-5866.002.patch
>
>
> There are few minor issues reported by jshint (javascript lint tool).
> This jira is to track and fix those issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to