[
https://issues.apache.org/jira/browse/YARN-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741375#comment-15741375
]
Sunil G commented on YARN-5866:
-------------------------------
Thanks [~akhilpb]
Mostly changes looks very good. I did test in my local environment and jshint
errors are completely fixed. Thanks
Few comments on code:
1.
{code}
normalizeSingleResponse(store, primaryModelClass, payload, id, requestType)
normalizeArrayResponse(store, primaryModelClass, payload, id, requestType)
{code}
These api's from serializer are overridden. So if you are removing params,
could you please put it in comments as you have done in adapters etc.
2. This warning is shown during compilation {{broccoli-babel-transpiler is
opting out of caching due to a plugin that does not provide a caching
strategy:}}. If its a simple fix, you could try handling here itself. Else we
can create another ticket to fix this broccoli version issue.
> [YARN-3368] Fix few issues reported by jshint in new YARN UI
> ------------------------------------------------------------
>
> Key: YARN-5866
> URL: https://issues.apache.org/jira/browse/YARN-5866
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
> Reporter: Akhil PB
> Assignee: Akhil PB
> Attachments: YARN-5866.001.patch, YARN-5866.002.patch,
> YARN-5866.003.patch
>
>
> There are few minor issues reported by jshint (javascript lint tool).
> This jira is to track and fix those issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
