[
https://issues.apache.org/jira/browse/YARN-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730269#comment-15730269
]
Daniel Templeton commented on YARN-5646:
----------------------------------------
Overall a well written doc. Minor comments:
* "list loaded nodes" should be "least loaded nodes"
* "In case of" should be "In the case of"
* "the NM on a node whose queue length is above the threshold, discards
opportunistic containers to meet this maximal value" should drop the comma and
be "an NM ..."
* It would be good to call out the defaults for the properties
* It's not obvious what the incremental properties do. Min and max are
self-explanatory, but I think you have to explain the increments.
* yarn.opportunistic-container-allocation.nodes-used needs more explanation. I
can guess what it does, but it would be better if you just explain it more.
* yarn.nm-container-queuing.min-queue-length needs more explanation. I have no
idea what it does from the doc. How can a minimum be enforced? What if there
are no jobs?
* Same for yarn.nm-container-queuing.min-queue-wait-time-ms
* "if a map task fail" should be "if a map task fails"
* "Also, when clicking" should drop the "Also"
* "the open JIRAs" should just be "the JIRAs" unless you plan to keep this doc
updated
* "not based on the allocated" is missing an object of the preposition
> Documentation for scheduling of OPPORTUNISTIC containers
> --------------------------------------------------------
>
> Key: YARN-5646
> URL: https://issues.apache.org/jira/browse/YARN-5646
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Priority: Blocker
> Attachments: YARN-5646.001.patch
>
>
> This is for adding documentation regarding the scheduling of OPPORTUNISTIC
> containers.
> It includes both the centralized (YARN-5220) and the distributed (YARN-2877)
> scheduling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
