[ 
https://issues.apache.org/jira/browse/YARN-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743531#comment-15743531
 ] 

Karthik Kambatla commented on YARN-5646:
----------------------------------------

Really well written docs, [~kkaranasos]. 

High-level comments:
# We should honor some character limit for the lines. 80 seems okay, but I am 
comfortable with longer lines if that makes more sense.
# Can we discuss execution before allocation, so we address any skepticism that 
users have before discussing how the allocation works?
# Can we automatically turn on AMRMProxy if someone enables 
distributed-opportunistic-scheduling? 
# Rebalancing node load: Since we do not provide details on how the RM arrives 
at targeted maximal queue length, may be we should keep it simple and just say 
the RM does it?
# The configs don't seem to follow general YARN conventions of 
{{yarn.resourcemanager}}, {{yarn.nodemanager}}, or {{yarn.scheduler}}. 
Following these would make it clear what config files each config should make 
it to. Also, are all the configs necessary? e.g. is 
clusterwide_min_queue_length necessary? Can't a node not support opportunistic 
execution? Also, can we not leave the queue lengths to nodes?
# In the future work, you mention YARN-5292 (pausing containers), but the 
description only mentions preemption and never pausing containers. 

I wasn't sure about the best way for minor comments, so will send you a diff 
capturing my suggested changes offline. 

> Documentation for scheduling of OPPORTUNISTIC containers
> --------------------------------------------------------
>
>                 Key: YARN-5646
>                 URL: https://issues.apache.org/jira/browse/YARN-5646
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>            Priority: Blocker
>         Attachments: YARN-5646.001.patch
>
>
> This is for adding documentation regarding the scheduling of OPPORTUNISTIC 
> containers.
> It includes both the centralized (YARN-5220) and the distributed (YARN-2877) 
> scheduling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to