[ https://issues.apache.org/jira/browse/YARN-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731622#comment-15731622 ]
Bibin A Chundatt commented on YARN-5849: ---------------------------------------- [~templedf]/[~miklos.szeg...@cloudera.com] sorry for delay. *Few comments* # Following check in {{CGroupsHandlerImpl#mountCGroupController}} is not required since check is already done {code} if (!enableCGroupMount) { LOG.warn("CGroup mounting is disabled - ignoring mount request for: " + controller.getName()); return; } {code} # Comment could be modified {code} // Make sure that Yarn cgroup path exists initializePreMountedCGroupController(controller) {code} Can we change to ""Make sure that Yarn cgroup hierarchy path exists"" *Query* [~templedf]/[~miklos.szeg...@cloudera.com] {{yarnHierarchy.mkdir()}} would create directory based on the umask of user with which NM is started. With umask of *022* LCE container launch should be fine. But cluster steps with umask of NM start user as 077 *drwx------* would be folder rights.This could cause permission issues rt?? Not related to current patch # TrafficControlBandwidthHandlerImpl can remove unused imports > Automatically create YARN control group for pre-mounted cgroups > --------------------------------------------------------------- > > Key: YARN-5849 > URL: https://issues.apache.org/jira/browse/YARN-5849 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2 > Reporter: Miklos Szegedi > Assignee: Miklos Szegedi > Priority: Minor > Attachments: YARN-5849.000.patch, YARN-5849.001.patch, > YARN-5849.002.patch, YARN-5849.003.patch, YARN-5849.004.patch, > YARN-5849.005.patch, YARN-5849.006.patch, YARN-5849.007.patch > > > Yarn can be launched with linux-container-executor.cgroups.mount set to > false. It will search for the cgroup mount paths set up by the administrator > parsing the /etc/mtab file. You can also specify > resource.percentage-physical-cpu-limit to limit the CPU resources assigned to > containers. > linux-container-executor.cgroups.hierarchy is the root of the settings of all > YARN containers. If this is specified but not created YARN will fail at > startup: > Caused by: java.io.FileNotFoundException: > /cgroups/cpu/hadoop-yarn/cpu.cfs_period_us (Permission denied) > org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler.updateCgroup(CgroupsLCEResourcesHandler.java:263) > This JIRA is about automatically creating YARN control group in the case > above. It reduces the cost of administration. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org