[
https://issues.apache.org/jira/browse/YARN-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736662#comment-15736662
]
Miklos Szegedi commented on YARN-5849:
--------------------------------------
Thank you, [~bibinchundatt] for the review! I addressed the three comments that
you had in the next patch.
In terms of umask, it should not be an issue in this case, since the node
manager creates and uses the directories itself. The cgroup directory is not
passed to the container.
This raises an interesting question though. Probably we want to change
File.mkdir() to limit the permissions to "rwx------" on all YARN cgroups
directories regardless of umask. But since this affects the existing
createCGroup method as well, I would address it in another Jira.
{code}
Files.createDirectory(path, PosixFilePermissions
.asFileAttribute(PosixFilePermissions.fromString("rwx------")));
{code}
> Automatically create YARN control group for pre-mounted cgroups
> ---------------------------------------------------------------
>
> Key: YARN-5849
> URL: https://issues.apache.org/jira/browse/YARN-5849
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Minor
> Attachments: YARN-5849.000.patch, YARN-5849.001.patch,
> YARN-5849.002.patch, YARN-5849.003.patch, YARN-5849.004.patch,
> YARN-5849.005.patch, YARN-5849.006.patch, YARN-5849.007.patch
>
>
> Yarn can be launched with linux-container-executor.cgroups.mount set to
> false. It will search for the cgroup mount paths set up by the administrator
> parsing the /etc/mtab file. You can also specify
> resource.percentage-physical-cpu-limit to limit the CPU resources assigned to
> containers.
> linux-container-executor.cgroups.hierarchy is the root of the settings of all
> YARN containers. If this is specified but not created YARN will fail at
> startup:
> Caused by: java.io.FileNotFoundException:
> /cgroups/cpu/hadoop-yarn/cpu.cfs_period_us (Permission denied)
> org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler.updateCgroup(CgroupsLCEResourcesHandler.java:263)
> This JIRA is about automatically creating YARN control group in the case
> above. It reduces the cost of administration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]