[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763606#comment-15763606
]
Sunil G commented on YARN-5956:
-------------------------------
I went through patch one more time.
Some doubts:
1. In {{checkAccess}} java doc comment, you mentioned {{uhe user}}. Could you
please help to use real name instead of abbreviation (I could not understand
this :-))
2. If we could pass ApplicationAccessType also to {{verifyUserAccessForRMApp}},
we can also have this code used in {{getApplicationReport}}. Ideally we should
be able to use verifyUserAccessForRMApp and getCallerUgi in all places to avoid
common code duplicated. Is that possible?
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch, YARN-5956.02.patch,
> YARN-5956.03.patch, YARN-5956.04.patch, YARN-5956.05.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
