[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764549#comment-15764549
]
Sunil G commented on YARN-5956:
-------------------------------
Thanks [~lewuathe]. After checking a bit more about
{{verifyUserAccessForRMApp}}, looks like it also call *checkAccess* and audit
logs if any failure (access control violations) are there. And many existing
caller of this {{verifyUserAccessForRMApp}} is again calling {{checkAccess}}
independently. For eg: {{failApplicationAttempt}}. It invokes
{{verifyUserAccessForRMApp}} and also calls checkAccess later. This is not
correct.
For few apis, we can still call {{verifyUserAccessForRMApp}} and remove
{{checkAccess}}. But for some apis, it may not be possible. Could you please
check the same.
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch, YARN-5956.02.patch,
> YARN-5956.03.patch, YARN-5956.04.patch, YARN-5956.05.patch, YARN-5956.06.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
