[ 
https://issues.apache.org/jira/browse/YARN-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764456#comment-15764456
 ] 

Arun Suresh commented on YARN-5216:
-----------------------------------

Missed a few comments:
# I feel its more apt to rename 'killOpportunisticContainers()' method to maybe 
'reclaimOpportunisticContainerResources()' or 
'preemptOpportunisticContainers()'.
#  Similarly, 'pickOpportunisticContainersToKill()' -> 
'pickOpportunisticContainersToReclaimResources()' / 
'pickOpportunisticContainersToPreempt()'
# In the {{if (usePauseEventForPreemption)..}} clause, instead of duplicating 
the {{LOG.info}}, you can maybe pull it out and parametrize the action 
(kill/pause) performed.
# We changed the yarn config parameter names a bit in YARN-5646, can you take a 
look and make sure this also conforms ?

> Expose configurable preemption policy for OPPORTUNISTIC containers running on 
> the NM
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-5216
>                 URL: https://issues.apache.org/jira/browse/YARN-5216
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: distributed-scheduling
>            Reporter: Arun Suresh
>            Assignee: Hitesh Sharma
>              Labels: oct16-hard
>         Attachments: YARN-5216-YARN-5972.001.patch, 
> YARN-5216-YARN-5972.002.patch, YARN-5216-YARN-5972.003.patch, 
> YARN-5216-YARN-5972.004.patch, YARN5216.001.patch, yarn5216.002.patch
>
>
> Currently, the default action taken by the QueuingContainerManager, 
> introduced in YARN-2883, when a GUARANTEED Container is scheduled on an NM 
> with OPPORTUNISTIC containers using up resources, is to KILL the running 
> OPPORTUNISTIC containers.
> This JIRA proposes to expose a configurable hook to allow the NM to take a 
> different action.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to