[
https://issues.apache.org/jira/browse/YARN-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812128#comment-15812128
]
Eric Payne commented on YARN-5889:
----------------------------------
bq. Since number of active users are changed, we need to recalculate all active
users limits, correct?
Correct. Comparing each user's "cached recompute count" value against the the
queue's value should trigger that to happen when {{getComputedActiveUserLimit}}
or {{getComputedUserLimit}} is called for each specific user.
bq. I need to have 2 cacheLimit in user data structure (one for active user and
another for all users).
Are you asking if we need two versions of {{cachedRecalcULCount}} in the
{{User}} class? If that's the question, then, no, I don't think so. The queue
value will change for all of the conditions outlined in [~jlowe]'s [comment
(above)|https://issues.apache.org/jira/browse/YARN-5889?focusedCommentId=15745552&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15745552],
and that will trigger the recalculation.
However, I do think {{reComputeUserLimits}} needs to be modified to update
{{preComputedUserLimit.get}} when recomputing user limits. That is not done
anywhare in the current patch.
> Improve user-limit calculation in capacity scheduler
> ----------------------------------------------------
>
> Key: YARN-5889
> URL: https://issues.apache.org/jira/browse/YARN-5889
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5889.0001.patch,
> YARN-5889.0001.suggested.patchnotes, YARN-5889.v0.patch, YARN-5889.v1.patch,
> YARN-5889.v2.patch
>
>
> Currently user-limit is computed during every heartbeat allocation cycle with
> a write lock. To improve performance, this tickets is focussing on moving
> user-limit calculation out of heartbeat allocation flow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
